Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment box data-width="100%" not working #53

Closed
Fonger opened this issue Aug 16, 2015 · 3 comments
Closed

Comment box data-width="100%" not working #53

Fonger opened this issue Aug 16, 2015 · 3 comments

Comments

@Fonger
Copy link

Fonger commented Aug 16, 2015

According to Facebook document,
data-width="100%" will make the comment box full width of the parent element
I've tested it and it's working with standard Facebook init

However, this is not working on angular-easyfb. The whole comment box is gone
I inspect the element created by FB sdk, and found that the width becomes 0, which causes the comment box invisible.

I've tried other width such as 500px and 1000px and it's working.

Plunkr: (Please select comment tab)
http://plnkr.co/edit/ZILG9JG9PnzOB9xjuc6q?p=preview

@Fonger Fonger changed the title data-width="100%" not working Comment box data-width="100%" not working Aug 16, 2015
@pc035860
Copy link
Owner

Hi @Fonger ,

Thanks for reporting. I've fixed the issue and it's on master now.
Let me know if something wrong. Or I'll make a release later.

@Fonger
Copy link
Author

Fonger commented Aug 23, 2015

@pc035860 Thank you. It's working now. Hope you can update the version on bower as well.

@Fonger Fonger closed this as completed Aug 24, 2015
@pc035860
Copy link
Owner

I just pushed a new tag v1.3.2. It should be on bower in a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants