Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fap won't run on Stable FW 0.74.2 #1

Closed
I-Sketchii-I opened this issue Jan 5, 2023 · 4 comments
Closed

fap won't run on Stable FW 0.74.2 #1

I-Sketchii-I opened this issue Jan 5, 2023 · 4 comments

Comments

@I-Sketchii-I
Copy link

At line ~28, itoa is used to convert autofire_delay values to str type and store it in the autofire_delay_str buffer
it looks like this is used to show the autofire delay in the GUI screen

when trying to compile with flipper zero FW:

fbt: warning: build\f7-firmware-D\.extapps\usb_hid_autofire.fap: app won't run. Unresolved symbols: {'itoa'} (in API, but disabled: {'itoa'})
validate_app_imports, line 204, in file "D:\Flipper Zero Stuff\flipperzero-firmware\scripts\fbt_tools\fbt_extapps.py"

itoa appears to be disabled in the official flipper zero FW API. The app compiles and runs if you comment out line 28:
//itoa(autofire_delay, autofire_delay_str, 10);

I am not skilled in programming but I commented out lines 27 & 28 and just replaced autofire_delay_str in line 41 with "10" as a dumb but simple solution
Sorry if this should've been a PR or something, I just wanted to document what I did to get the .fap working on my flipper

@pbek
Copy link
Owner

pbek commented Jan 5, 2023

Thank you for mentioning! It really doesn't seem to build any more. I just tested it in https://github.com/pbek/usb_hid_autofire/actions/runs/3850371823/jobs/6560439751. They seem to have removed it. I'll take a look at it.

pbek added a commit that referenced this issue Jan 6, 2023
@pbek
Copy link
Owner

pbek commented Jan 6, 2023

Can you try again please?

@I-Sketchii-I
Copy link
Author

I just tried compiling again with the new changes and it works! Thank you! :)

@pbek
Copy link
Owner

pbek commented Jan 7, 2023

Great! 😁

pbek added a commit that referenced this issue Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants