Option to delete old drafts when sending or saving. #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please squash these into one commit for easier reviewing. Moreover, if you add a new command you might need to build and commit the docs to make sure that the travis built bot doesn't fail.. |
|
Okay, squashed and built. |
pazz
reviewed
Apr 12, 2019
| @@ -280,6 +316,47 @@ def __init__(self, mail=None, envelope=None, **kwargs): | |||
| ui.dbman.add_message(path, account.sent_tags + initial_tags) | |||
| await ui.apply_command(globals.FlushCommand()) | |||
|
|
|||
| # if provided, delete the old draft | |||
There was a problem hiding this comment.
This looks very much like the code in SendCommand above. why the duplication?
|
Referencing #1044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run the 'editnew' command in a thread view, if the email you are copying has the 'draft' flag, it will pass this message on to the envelope object. When the user saves or sends a draft, they will be prompted to delete the old draft.
I do not currently have alot set up to send emails, so someone would need to test that process. But I believe it should work, it's not really any different from the process when saving new drafts.
Let me know if you'd like me to change anything.