Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial driver for ACCESS-ESM1.6 #563

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

blimlim
Copy link
Contributor

@blimlim blimlim commented Feb 11, 2025

Closes the first part of #554

This PR adds an initial driver for ESM 1.6. This first version duplicates the ESM1.5 driver which until now has been used for ESM1.6. ESM1.6 specific changes (e.g. adding new configuration files, removing matm support) will be added in separate PRs in order to have clearer diffs.

The most contentious part could be the file and model names – I tried to follow what I'd seen elsewhere but let me know if there are different conventions that would be better.

  • I chose the filename access_esm1p6.py based on accessom2.py, however added an underscore for clarity since they are used in other drivers like cesm_cmeps.py include them.
  • For naming the model class, I used AccessEsm1p6, following other classes like AccessOm2.
  • For the model-type I used access-esm1.6, following access-om2 in the OM2 driver, and also matching what is used in the spack packages.

Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like your naming choices. Consistent with previous practice, and where it differs it improves clarity.

@blimlim blimlim merged commit c452587 into payu-org:master Feb 16, 2025
7 checks passed
@blimlim blimlim deleted the 554-esm1p6-driver branch February 16, 2025 23:03
@blimlim
Copy link
Contributor Author

blimlim commented Feb 16, 2025

Thanks @aidanheerdegen! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants