Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting restart time in access-om3 driver #556

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Remove setting restart time in access-om3 driver #556

merged 2 commits into from
Feb 11, 2025

Conversation

anton-seaice
Copy link
Contributor

@anton-seaice anton-seaice commented Feb 6, 2025 •
edited
Loading

Closes #555

This lets the user set the restart time as they desire!

@coveralls
Copy link

Coverage Status

coverage: 59.412% (+0.2%) from 59.182%
when pulling a14c885 on 555-rm-om3-restart-setting
into 083a22b on master.

@anton-seaice anton-seaice mentioned this pull request Feb 6, 2025
Merged
@anton-seaice anton-seaice marked this pull request as ready for review February 10, 2025 05:08
@anton-seaice anton-seaice self-assigned this Feb 10, 2025
dougiesquire
dougiesquire approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anton-seaice

@dougiesquire
Copy link
Collaborator

dougiesquire commented Feb 11, 2025 •
edited
Loading

Oh, let me fix the PyPA build issue then we can rebase this

This has already been fixed: #559

@jo-basevi
Copy link
Collaborator

Oh, let me fix the PyPA build issue then we can rebase this

Oops sorry I should've updated these PRs but it's hopefully already fixed in #560 that was merged this morning

@anton-seaice anton-seaice merged commit 2241178 into master Feb 11, 2025
7 checks passed
@anton-seaice anton-seaice deleted the 555-rm-om3-restart-setting branch February 11, 2025 02:29
@anton-seaice anton-seaice mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougiesquire dougiesquire dougiesquire approved these changes

Assignees

@anton-seaice anton-seaice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

payu setting restart time in access-om3 driver
4 participants
@anton-seaice @coveralls @dougiesquire @jo-basevi