-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmd-line flag to disable metadata + UUID generation and commits #447
Add cmd-line flag to disable metadata + UUID generation and commits #447
Conversation
Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-08-22 04:01:06 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that touched a lot! I appreciate the time it took to make all those changes.
Looks good to me. I have a question about the best way to propagate the argument through to subsequent commands, but trust your judgement and am happy to leave as-is, just wanted to point it out.
f89bff0
to
c2d10c3
Compare
As the intention was to add a command-line argument to make it easier to update manifests for released configurations, running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, and sorry for the extra work that wasn't required.
Add cmd line flag
--metadata-off
/-M
(better names?) to payu subcommands to disable metadata files or UUIDs being created. This uses control directory for experiment names. (so equivalent tometadata: enable: false
inconfig.yaml
)Added this flag to sub-commands that create an Experiment class instance - so archive, collate, profile, run, setup, sweep and sync.
Closes #446