Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Magento\Support\Model\Report\Group\Modules\Modules class #3

Merged

Conversation

rikuheinaaho-Pinja
Copy link
Contributor

@rikuheinaaho-Pinja rikuheinaaho-Pinja commented May 20, 2024

The class Magento\Support\Model\Report\Group\Modules\Modules doesn't exist in Magento Open Source -version. So this adds support for it.

Usage of Magento\Support\Model\Report\Group\Modules\Modules throws an error during bin/magento setup:di:compile due to the class not existing so replacing it with Magento\Framework\Module\Manager.

Change the code to work with the new class.

The whole error:

In ClassReader.php line 57:
                                                                                                                                        
  Impossible to process constructor argument Parameter #1 [ <required> 
  Magento\Support\Model\Report\Group\Modules\Modules $modules ]
  of Paytrail\PaymentServiceGraphQl\Plugin\GetFrontendUrl class                                                                          
                                                                                                                                        

In GetParameterClassTrait.php line 34:
                                                                             
  Class "Magento\Support\Model\Report\Group\Modules\Modules" does not exist

Usage of `Magento\Support\Model\Report\Group\Modules\Modules` throws
an error during `bin/magento setup:di:compile` due to the class not
existing so replacing it with `Magento\Framework\Module\Manager`.

Change the code to work with the new class.
@mattijv
Copy link

mattijv commented May 21, 2024

Would be nice to get this merged (or some other solution to the issue), so we don't have to fork the package to make it usable in the OS version. 🙏

@konrad-konieczny konrad-konieczny merged commit 4f2e701 into paytrail:master Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants