Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add card fields types #427

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Feature/add card fields types #427

merged 2 commits into from
Apr 9, 2024

Conversation

sebastianfdz
Copy link
Contributor

@sebastianfdz sebastianfdz commented Apr 9, 2024 •
edited
Loading

Ticket: https://paypal.atlassian.net/browse/DTPPCPSDK-2090

Consolidating types for our react library to add support for card fields in subsequent PRs.

Related PR for fixing card fields types: paypal/paypal-js#482

@sebastianfdz sebastianfdz requested a review from a team as a code owner April 9, 2024 16:41
siddy2181
siddy2181 approved these changes Apr 9, 2024
View reviewed changes
Copy link

@siddy2181 siddy2181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Should we run typecheck and lint locally once?

@sebastianfdz sebastianfdz merged commit ae10034 into main Apr 9, 2024
2 checks passed
@sebastianfdz sebastianfdz deleted the feature/add-card-fields-types branch April 10, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddy2181 siddy2181 siddy2181 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianfdz @siddy2181