refactor: simplify template literals in types definition (#437)

Co-authored-by: Andriy Kuts <[email protected]>
paypal · May 29, 2024 · 672a48d · 672a48d
1 parent 066a63e
commit 672a48d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/components/PayPalScriptProvider.test.tsx b/src/components/PayPalScriptProvider.test.tsx
@@ -5,6 +5,7 @@ import { loadScript, PayPalScriptOptions } from "@paypal/paypal-js";
 import { PayPalScriptProvider } from "./PayPalScriptProvider";
 import { usePayPalScriptReducer } from "../hooks/scriptProviderHooks";
 import { SCRIPT_ID, SDK_SETTINGS } from "../constants";
+import { DISPATCH_ACTION } from "../types/enums";
 
 jest.mock("@paypal/paypal-js", () => ({
     loadScript: jest.fn(),
@@ -290,7 +291,7 @@ function ResetParamsOnClick({
 
     function onClick() {
         dispatch({
-            type: "resetOptions",
+            type: DISPATCH_ACTION.RESET_OPTIONS,
             value: options as PayPalScriptOptions,
         });
     }

diff --git a/src/types/scriptProviderTypes.ts b/src/types/scriptProviderTypes.ts
@@ -10,19 +10,19 @@ export interface ReactPayPalScriptOptions extends PayPalScriptOptions {
 
 export type ScriptReducerAction =
     | {
-          type: `${DISPATCH_ACTION.LOADING_STATUS}`;
+          type: DISPATCH_ACTION.LOADING_STATUS;
           value: SCRIPT_LOADING_STATE;
       }
     | {
-          type: `${DISPATCH_ACTION.LOADING_STATUS}`;
+          type: DISPATCH_ACTION.LOADING_STATUS;
           value: { state: SCRIPT_LOADING_STATE; message: string };
       }
     | {
-          type: `${DISPATCH_ACTION.RESET_OPTIONS}`;
+          type: DISPATCH_ACTION.RESET_OPTIONS;
           value: ReactPayPalScriptOptions;
       }
     | {
-          type: `${DISPATCH_ACTION.SET_BRAINTREE_INSTANCE}`;
+          type: DISPATCH_ACTION.SET_BRAINTREE_INSTANCE;
           value: BraintreePayPalCheckout;
       };