FISH-6081-Payara6-cdi-4.0-upgrade #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sey" This reverts commit 1dc582d.
…upgrade-shim-dependencies
# Conflicts: # appserver/admingui/pom.xml # appserver/extras/javaee/manifest-jar/pom.xml # appserver/packager/external/jakarta-ee9-shim/pom.xml # appserver/web/web-glue/src/main/java/org/glassfish/web/jsp/JSPCompiler.java # pom.xml
# Conflicts: # appserver/extras/javaee/manifest-jar/pom.xml # appserver/packager/external/jakarta-ee9-shim/pom.xml # pom.xml
…6-cdi-4.0-upgrade
… async servlet call
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
Pandrex247
requested changes
Jun 23, 2022
appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java
Outdated
Show resolved
Hide resolved
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
3 similar comments
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
Pandrex247
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FISH-6081 Payara6 CDI 4.0 upgrade
Description
This is the PR to upgrade cdi to the latest version compatible with Jakarta EE 10. This include the following upgraded versions
Important Info
Blockers
Testing
New tests
CDI full passing tests:
[mvn.test] [INFO] Tests run: 1831, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,082.431 s - in TestSuite
[mvn.test] [INFO]
[mvn.test] [INFO] Results:
[mvn.test] [INFO]
[mvn.test] [INFO] Tests run: 1831, Failures: 0, Errors: 0, Skipped: 0
Testing Performed
executing the tck from the cditck-porting project
Testing Environment
Ubuntu 20.04, Azul JDK 11, Maven 3.6.1, ant 1.10.12
Documentation
Notes for Reviewers
Still working to configure correctly the CDI Core profile. I identified an issue that cause to execute around 1295 tests but the correct number should be 725