Fix Elixir 1.15 warning, require Elixir 1.11+ & bump Ecto/Postgrex requirements #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2023
|
@thbar thanks for a PR! I think that CI currently does not work because of legacy Ubuntu version that you've mentioned. I'm looking forward to merge this PR, but can you try to fix CI before we merge it? |
|
@pawurb I will look into CI fixes in the same PR to keep things simple! Will keep you posted. |
This is done to fix CI & address https://brianmeeker.me/2023/05/24/otp-26-ecto-dynamic-error/
thbar
changed the title
|
@pawurb I've fixed the CI (at the cost of bumping some requirements), but I believe you'll have to fix the settings to remove some jobs from the expected statuses. Other than that, the tests pass. |
|
@thbar thanks! It's now released as 0.7.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple maintenance points.
Move to Elixir 1.11+ & fix Elixir 1.15 warning
As seen in other places:
There is a trend to move to Elixir 1.11+ (oldest maintained version) all while removing the
Logger.warnin favour ofLogger.warning.This PR addresses that.
Bump Ecto/Postgrex minimal versions & fix CI
The PR also addresses:
since the CI system was broken.
As described in https://brianmeeker.me/2023/05/24/otp-26-ecto-dynamic-error/, Ecto had to be bumped in the "lock" file at least for OTP 26, but to be able get there on CI I ended up bumping
mix.exsversions (rather than the lock file) for Ecto & Postgrex. I believe this is acceptable since previous constraints were on oldish versions.