Logging and testing #38
Conversation
| throw new IllegalArgumentException("Horses cannot be empty."); | ||
| } | ||
|
|
||
| this.horses = horses; | ||
| LOGGER.debug("створення Hippodrome, коней [" + horses.size() + "]"); |
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
I understand, but I was sticking to the task
| throw new IllegalArgumentException("Distance cannot be negative."); | ||
| } | ||
|
|
||
| this.name = name; | ||
| this.speed = speed; | ||
| this.distance = distance; | ||
|
|
||
| LOGGER.debug("створення Horse, ім'я [" + name + "], " + "швидкість [" + speed + "]"); |
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
I understand, but I was sticking to the task
| @@ -15,6 +20,8 @@ public static void main(String[] args) throws Exception { | |||
| ); | |||
| Hippodrome hippodrome = new Hippodrome(horses); | |||
|
|
|||
| LOGGER.info("Початок стрибків. Кількість учасників " + horses.size()); | |||
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
I understand, but I was sticking to the task
| @@ -23,6 +30,8 @@ public static void main(String[] args) throws Exception { | |||
|
|
|||
| String winnerName = hippodrome.getWinner().getName(); | |||
| System.out.println(winnerName + " wins!"); | |||
|
|
|||
| LOGGER.info("Закінчення стрибків. Переможець: " + winnerName); | |||
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
There was a problem hiding this comment.
don't commit logs with debug level, also this message is not informative, delete this log
I understand, but I was sticking to the task
src/main/java/Main.java
Outdated
| @@ -23,6 +30,8 @@ public static void main(String[] args) throws Exception { | |||
|
|
|||
| String winnerName = hippodrome.getWinner().getName(); | |||
| System.out.println(winnerName + " wins!"); | |||
There was a problem hiding this comment.
don't use System.out.println, if u need print some info, use LOG.info()
There was a problem hiding this comment.
don't use System.out.println, if u need print some info, use LOG.info()
Ok, but i`m fork this code, It's not my job
src/test/java/HippodromeTest.java
Outdated
| import static org.mockito.Mockito.verify; | ||
|
|
||
| public class HippodromeTest { | ||
| private final List<Horse> horses = new ArrayList<>(Arrays.asList( |
There was a problem hiding this comment.
why do u create list in this style new ArrayList<List.of()) just us List.of it will return list of Hourses, or u can make it simplier, create a method private List prepareHourses() {
List hourses = new ArrayList();
for(int i = 0; i<30; i++) {
hourses.add(new Hourse("hourse" + i; 10,100);
}
return hourses;
}
| } | ||
|
|
||
| @Test | ||
| void getNameTest() { |
| @Disabled | ||
| @Test | ||
| @Timeout(value = 22) | ||
| void testMainForTimeout() { |
No description provided.