updated rkyv with reexported bytecheck #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkatychev
commented
Jul 13, 2023
| @@ -75,7 +74,7 @@ ndarray = ["dep:ndarray"] | |||
| proptest = ["dep:proptest"] | |||
| rand = ["dep:rand"] | |||
| rkyv = ["dep:rkyv"] | |||
| rkyv-safe = ["dep:bytecheck", "rkyv/validation"] | |||
| rkyv-safe = ["rkyv/validation"] | |||
There was a problem hiding this comment.
Ideally this should be renamed to rkyv-validation to mirror the feature flag name upstream but that is a breaking change or there would have to be a #[cfg(any("rkyv-safe", "rkyv-validation"))] interim approach.
There was a problem hiding this comment.
This is a good idea. While we need to keep rkyv-safe for backwards compatibility, it'd be easy to introduce a new feature with this name, particularly if it makes discoverability easier..
paupino
force-pushed
the
feat/bytecheck_removal
branch
from
828e8d0 to
524711a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream PR removes
bytecheckas a direct dependency forrkyv/validation:rkyv/rkyv#344
Thus it allows downstream crates such as this one to maintain one version for both
rkyv&bytecheck