Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parity scale codec #547
base: master
Are you sure you want to change the base?
Add parity scale codec #547
Changes from 4 commits
27c62bc
394d8f8
204d127
610096f
b896337
25f0849
031d203
deeb242
091d715
67efda9
29d3e2e
a6d5caf
951512d
03ce442
f18e57c
aacdefd
1686b69
ede308d
6cfccf3
1c80137
c3802db
c4d4d3e
829355a
f02f5ac
d323dd4
10ee2ee
80e9f08
aa2c3d3
bacc60b
999bb02
179039a
d72e787
4666555
65ec77a
e7511dc
62cf912
d778de7
bbcc77a
e1b54cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note (no change required): these
derive
attributes are causing a bit of code bloat. I want to rethink how we do this in v2. It may be by exposing a wrapperstruct
and aliasing it however all in all, this current approach isn't entirely scalable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fix the code formatting error in the build:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this line: