ed25519: fix edwardsToMontgomery formula; implement edwardsToMontgomeryPriv #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31
This fixes the formula used in
edwardsToMontgomery
.I also implemented the equivalent transformation for private keys
edwardsToMontgomeryPriv
and added a bunch of tests.Is there a reason
ed25519-addons.test.js
wasn't being run duringnpm test
? I included it as well.My IDE rearranged the imports and whitespace to fit prettier rules. If that's an issue I can revert.