Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dangling async work in tests #1348

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Avoid dangling async work in tests #1348

merged 4 commits into from
Sep 11, 2024

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Sep 11, 2024

This contains 3 things:

  • Drop node 16 from CI
    • the test runner in node 16 has a bug where nested beforeEach don't work correctly, so test runs hang or always fail
  • Clear timers we set when waiting for spies/watchers
    • this was causing CI runs to hang until GitHub killed them. now it should fail as normal
  • Move options to a scoped variable
    • this isn't required anymore but makes the code a bit more readable (it was a top level var before)

@43081j
test: use a scoped options object
11bf22d
@43081j
chore: remove node 16 support
962d959 
node 16.x is incapable of running the test suite thanks to one or more
bugs which never had their fixes backported. Primarily, the inability to
have nested `beforeEach` was fixed in all later versions but not in 16.
@43081j
test: wait for timer to avoid hanging tests
8feeb0a
@43081j
test: clear check timer to avoid hangs
0856113
@paulmillr paulmillr merged commit da7f03b into paulmillr:master Sep 11, 2024
9 of 10 checks passed
@43081j 43081j deleted the fixing-tests branch September 12, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@43081j @paulmillr