Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(encoding/mvt): support mvt marshal for GeometryCollection #89

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

dadadamarine
Copy link
Contributor

support collection marshaling in mvt.

@paulmach
Copy link
Owner

I agree with this PR. Why not support geometry collections by encoding each geometry separately. Makes sense. The only possible issue is that it's no longer a close mapping between geojson and mvt. if you go geojson -> mvt -> geojson the collection will become individual features. Not a big deal, but FYI.

However, this has nothing to do with winding-order. Winding-order refers to the individual rings within a single polygon. That is fully supported by the existing code.

@paulmach paulmach merged commit 53b70e2 into paulmach:master Apr 3, 2022
@paulmach
Copy link
Owner

paulmach commented Apr 3, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants