http: propagate tcp timeout errors #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
oviano
force-pushed
the
propagate_tcp_timeouts
branch
from
82e85f4 to
a4a31ca
Compare
src/http.h
Outdated
| @@ -33,6 +34,7 @@ typedef struct http_response { | |||
| char *headers; | |||
| char *body; | |||
| size_t body_size; | |||
| bool timed_out; | |||
There was a problem hiding this comment.
I don't really like adding a boolean in the response, I think time out should be an error just like you did for TCP.
|
That's fair enough, I'm not sure why I did it like that, come to think of it! Will fix it up in a bit. |
oviano
force-pushed
the
propagate_tcp_timeouts
branch
3 times, most recently
from
e7f7a3c to
36b7aa0
Compare
oviano
force-pushed
the
propagate_tcp_timeouts
branch
from
f843a28 to
ad29767
Compare
paullouisageneau
approved these changes
Sep 3, 2024
paullouisageneau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines two error codes for tcp_send/recv according to whether the error was a timeout or another error. This is used to fill in a new timed_out flag in the http response structure. Finally this is checked by the upnp protocol code to return PROTOCOL_ERR_TIMEOUT if necessary.
This means that if a protocol fails to complete successfully due to a TCP timeout it will be retried under the same system that is used for timing out waiting for broadcast responses.