Allow using system lib for all submodules #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
force-pushed
the
no_more_mandatory_submodules
branch
from
afd0348 to
abb622c
Compare
|
|
paullouisageneau
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdatachannel requires usrsctp, Plog and Nlohmann JSON (examples only) submodules.
This PR enable in CMake using system lib for those and add an option
PREFER_SYSTEM_LIBto enable allUSE_SYSTEM_.This change allows libdatachannel to be built and packaged on Debian and Fedora build-systems by packaging and providing all the dependencies independently since those build-systems do not support git submodules.