Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webpack-config): add minimal support for dual environment #15

Merged
merged 1 commit into from
Nov 30, 2018
Merged

feat(webpack-config): add minimal support for dual environment #15

merged 1 commit into from
Nov 30, 2018

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Nov 28, 2018 •
edited
Loading

adds multi env support #7

seanforyou23
seanforyou23 requested changes Nov 28, 2018
View reviewed changes
Copy link
Collaborator

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple of small nits, the main thing is the styles don't seem to be loading properly in production mode for me. Try running python -m SimpleHTTPServer 8080 in the dist directory and load it up in a browser for a quick and dirty sanity check.

ibolton336
ibolton336 commented Nov 28, 2018
View reviewed changes
seanforyou23
seanforyou23 reviewed Nov 29, 2018
View reviewed changes
@ibolton336 ibolton336 force-pushed the multi-env branch 2 times, most recently from 31f8001 to a8cdaa3 Compare November 30, 2018 17:00
seanforyou23
seanforyou23 approved these changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! LGTM

@seanforyou23 seanforyou23 merged commit 7c1df39 into patternfly:master Nov 30, 2018
@seanforyou23 seanforyou23 mentioned this pull request Nov 30, 2018
Closed
@ibolton336 ibolton336 deleted the multi-env branch November 30, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanforyou23 seanforyou23 seanforyou23 approved these changes

@cdcabrera cdcabrera Awaiting requested review from cdcabrera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibolton336 @seanforyou23