Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Iframe Routing Logic + Add Psuedo-404 Support #1131

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Refactor Iframe Routing Logic + Add Psuedo-404 Support #1131

merged 1 commit into from
Mar 23, 2020

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Mar 1, 2020

CleanShot 2020-03-01 at 14 26 06

Summary of changes:

  • Consolidates the iFrame routing logic to be less complex. Not a complete re-write here but definitely a bit less code than where we were previously at
  • Patches up some annoying browser history issues when going forward / backward
  • Adds "psuedo-404" support so trying to navigate to a Pattern Lab URL for a pattern that doesn't exist (ex. http://localhost:3000/?p=atoms-foobar) or clicking on a broken link within Pattern Lab should now take you to a simple 404 error message + link back to your main default page (see GIF above^) CC @thethomic

@sghoweri sghoweri requested a review from bmuenzenmeyer March 1, 2020 19:38
@sghoweri sghoweri added the uikit label Mar 1, 2020
@bmuenzenmeyer
Copy link
Member

works great @sghoweri !

@bmuenzenmeyer bmuenzenmeyer merged commit f89853e into dev Mar 23, 2020
@bmuenzenmeyer bmuenzenmeyer deleted the feature/add-404-support-plus-router-cleanup branch March 23, 2020 12:05
@sghoweri
Copy link
Contributor Author

Thanks @bmuenzenmeyer! 👍🏼

@mfranzke mfranzke mentioned this pull request Jan 4, 2023
Merged
38 tasks
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
@bmuenzenmeyer
Merge pull request pattern-lab#1131 from pattern-lab/feature/add-404-…
76495da 
…support-plus-router-cleanup

Refactor Iframe Routing Logic + Add Psuedo-404 Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer Awaiting requested review from bmuenzenmeyer

Assignees
No one assigned
Labels
uikit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sghoweri @bmuenzenmeyer @bolt-bot