Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vestigial configuration entries #745

Closed
6 of 8 tasks
bmuenzenmeyer opened this issue Nov 14, 2017 · 4 comments
Closed
6 of 8 tasks

Remove vestigial configuration entries #745

bmuenzenmeyer opened this issue Nov 14, 2017 · 4 comments
Labels
good first issue 🎓 help wanted 🆘 pinned 📌 Don't let stalebot clean this up staged for next release 🏁
Milestone
3.0.0

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Nov 14, 2017 •
edited by mbulfair
Loading

While documenting PL Node 3.0 configuration I found the following dead config entries:

  • ignored-extensions
  • ignored-directories

Check that these are removed from:

  • this repo
  • edition-node-gulp
  • edition-node-grunt
  • edition-node
  • edition-node-webpack
  • cli
@bmuenzenmeyer bmuenzenmeyer added this to the 3.0.0 milestone Nov 15, 2017
@raphaelokon raphaelokon mentioned this issue Nov 15, 2017
Open
@stale
Copy link

stale bot commented Jan 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the needs response label Jan 14, 2018
@stale stale bot removed the needs response label Jan 16, 2018
bmuenzenmeyer added a commit that referenced this issue Jan 20, 2018
@bmuenzenmeyer
fix(test configuration): Remove vestigial configuration entries
481fce9 
part of #745
This was referenced Jan 20, 2018
Merged
Open
@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Feb 2, 2018 •
edited
Loading

Updated pattern-lab/edition-node-grunt#31 to the furthest my appetite can take me at this time.

@mbulfair made any progress on your end?

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Mar 16, 2018
Closed
@bmuenzenmeyer
Copy link
Member Author

calling this done as a tracking issue has been opened in the comcast repo

mbulfair pushed a commit to Comcast/patternlab-edition-node-webpack that referenced this issue Mar 21, 2018
Address pattern-lab/patternlab-node#745 and #16 for config options
ec072ee
@mbulfair
Copy link

Removed from webpack edition for future releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🎓 help wanted 🆘 pinned 📌 Don't let stalebot clean this up staged for next release 🏁
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@bmuenzenmeyer @mbulfair