-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiding patterns with an underscore, but still being able to access the pattern with includes #210
Comments
I've seen use cases for this too. It should definitely be considered. |
Yes. It's borked in PL2 but @theorise is correct in his interpretation. PL2 also supports a dash at the beginning of a file name to denote "show in the pattern drop down but don't show in the 'view all' views." |
Nice - thanks for additional information. |
Oh wow -- I didn't even know I wanted this feature, but I do. Our "view On Wed, Dec 16, 2015 at 10:53 AM Brian Muenzenmeyer <
|
Yeah the more I think about this the more it makes a ton of sense. I do this on an internal instance of Pattern Lab with some base patterns that get parameterized downstream. The bases are pretty useless when used like this.. I'll get this in asap, per strong feedback! |
Hey @geoffp,
The way I deal with that stuff is to override the styles in
|
Internal Note Odd that this code does not appear to be functioning? There are no unit tests on the front-end menu generation, it's years old and 💩 Update |
@dmolsen I assume it should however be accessible via lineage links? |
This is live in |
@bradfrost just now took your advice on |
Great to hear! Happy new year! Brad Frost On Thu, Dec 31, 2015 at 9:54 AM, Geoff Pursell [email protected]
|
Would love this feature too! Very useful for when the base partial being imported doesn't need to be shown alone. |
@bmuenzenmeyer This does not seem to be working. I just updated my PatternLab-Node to the dev-branch version. My name is called The atom does not show up in the navigation or 'all' view, but also not in the template where I want to include the atom. I don't get any errors. |
I got this working in a copy of Not ideal but may work for now if you are in a pinch. I assume the preference by everybody would be to not include the underscore, but it might also signify that you are including an excluded pattern? Feedback appreciated |
That works. Thanks! I tried everything, but not this ... Would prefer it without the underscore |
According to the docs, if you append an underscore (_) to the pattern name it should "no longer show up in the drop-down navigation, the media pattern sub-type "view all" page, nor the style guide".
I want to hide a pattern from the drop-down and the 'view all', however I still want to use the pattern as an include, and for the patterns using it to be displayed (as they have no underscore in their file name/parent folder name).
If I try this, the builder will just tell me that the pattern is missing 'Could not find pattern with key atoms-$'.
The text was updated successfully, but these errors were encountered: