Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fp8 types exposed in jax.numpy. #251

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

liudangyi
Copy link
Contributor

No description provided.

@patrick-kidger
Copy link
Owner

Thank you for the contribution! These all look good to me. Do you have a link to any documentation on these?

@liudangyi
Copy link
Contributor Author

Yes. They are defined in https://github.com/jax-ml/jax/blob/main/jax/_src/dtypes.py#L92-L97. I have updated the patch to include a link.

@hsinyuu
Copy link

hsinyuu commented Oct 3, 2024

Hi @patrick-kidger, can we merge this change into main?

@patrick-kidger
Copy link
Owner

Yes. They are defined in https://github.com/jax-ml/jax/blob/main/jax/_src/dtypes.py#L92-L97. I have updated the patch to include a link.

Is there any proper documentation, though? Not just their existence in the source code. I'm a little hesitant to expand our own public API to include undocumented features.

(Advanced users such as yourself can continue to subclass AbstractDtype to obtain jaxtyping annotations for these dtypes anyway, after all.)

Hi @patrick-kidger, can we merge this change into main?

As with many open-source projects this is a volunteer effort that happens primarily in my evenings and weekends. Please have a little patience.

@liudangyi
Copy link
Contributor Author

Unfortunately I cannot find any public document about fp8. jax-ml/jax@d203926 is the first commit adding fp8 support to JAX, and there's no additional info attached.

@liudangyi
Copy link
Contributor Author

Kindly reminder on this PR.

@patrick-kidger
Copy link
Owner

Since these dtypes are not yet public in JAX then I don't think we should make them public either, I'm afraid.

That might change in the future, though :)

@jakevdp
Copy link

jakevdp commented Nov 19, 2024

Hi Patrick – these are public symbols in JAX, so it should be safe to add them here. Thanks!

@patrick-kidger patrick-kidger merged commit 51345dd into patrick-kidger:main Nov 19, 2024
2 checks passed
@patrick-kidger
Copy link
Owner

What greater confirmation could we ask for :)
Thanks Jake -- in that case, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants