Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Lighthouse audit details #12

Closed
jeanlucaslima opened this issue Jul 30, 2019 · 2 comments
Closed

Small Lighthouse audit details #12

jeanlucaslima opened this issue Jul 30, 2019 · 2 comments

Comments

@jeanlucaslima
Copy link

Just two items from Lighthouse that may impact score and performance could be added, they are:

  • font-auto attribute to load text before the font loads
  • <meta> description attribute (maybe with variable added to _config.yml

I added this in my instance, leaving it up as suggestion.

@patdryburgh
Copy link
Owner

Thanks for the feedback, @jeanlucaslima! The missing <meta> description was definitely an oversight (the default _config.yml file includes a description variable, it just wasn't included in the default.html template.

As for loading text before the font loads, I added the font-display: auto declaration to the @font-face rule set in _fonts.scss. I assume that is what you meant as I couldn't find any reference online to a font-auto attribute. If I'm incorrect, I welcome further insight into the issue.

One last question, I'm not sure what a “Lighthouse audit” is. Can you please fill me in?

Thanks again for the feedback! Hope you enjoy the theme :)

@jeanlucaslima
Copy link
Author

@patdryburgh lighthouse is a tool that Google develops to "audit" pages in how fast they load and shows you a report on what points are not in best performance. That's also where I got the font-auto tip. You can try it on Google Chrome console, go to "Audits" tab and generate a new report.

GhostofSky pushed a commit to GhostofSky/DPGATranslations that referenced this issue Apr 21, 2023
GhostofSky added a commit to GhostofSky/DPGATranslations that referenced this issue Apr 21, 2023
GhostofSky pushed a commit to GhostofSky/DPGATranslations that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants