Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple wildcards in stream store #675

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added this to the 3.8.0 milestone Jan 15, 2025
@DavidBadura DavidBadura added the enhancement New feature or request label Jan 15, 2025
@DavidBadura DavidBadura changed the title allow multiple wildcarts allow multiple wildcards in stream store Jan 15, 2025
@DavidBadura DavidBadura enabled auto-merge January 15, 2025 12:10
@DavidBadura DavidBadura force-pushed the allow-multiple-wildcards branch from de73617 to d6476e8 Compare January 15, 2025 12:10
@DavidBadura DavidBadura force-pushed the allow-multiple-wildcards branch from d6476e8 to 5483417 Compare January 15, 2025 12:13
Copy link

github-actions bot commented Jan 15, 2025

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 968.600μs (±0.00%) | 1.020ms (±0.00%)   | -5.01%    | 34.632mb        | 34.640mb   | -0.02%      |
| benchLoad10000Events ()                | 51.810ms (±0.00%)  | 51.729ms (±0.00%)  | +0.16%    | 34.632mb        | 34.128mb   | +1.48%      |
| benchSave1Event ()                     | 984.700μs (±0.00%) | 998.900μs (±0.00%) | -1.42%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Events ()                | 220.440ms (±0.00%) | 225.231ms (±0.00%) | -2.13%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.537s (±0.00%)    | 8.240s (±0.00%)    | -8.53%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.889s (±0.00%)    | 4.928s (±0.00%)    | -0.81%    | 34.128mb        | 34.128mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 52.592ms (±0.00%)  | 52.556ms (±0.00%)  | +0.07%    | 34.132mb        | 34.132mb   | 0.00%       |
| benchLoad10000Events ()                | 910.500μs (±0.00%) | 915.000μs (±0.00%) | -0.49%    | 34.132mb        | 34.132mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 76.873ms (±0.00%) | 75.490ms (±0.00%) | +1.83%    | 34.597mb        | 34.597mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.209s (±0.00%) | 3.205s (±0.00%) | +0.11%    | 46.745mb        | 46.745mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 887.300μs (±0.00%) | 895.400μs (±0.00%) | -0.90%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchLoad10000Events ()                | 90.156ms (±0.00%)  | 89.356ms (±0.00%)  | +0.90%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave1Event ()                     | 1.536ms (±0.00%)   | 1.430ms (±0.00%)   | +7.42%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000Events ()                | 252.035ms (±0.00%) | 248.621ms (±0.00%) | +1.37%    | 35.259mb        | 35.259mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.680s (±0.00%)   | 11.840s (±0.00%)   | -1.35%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.133s (±0.00%)    | 9.076s (±0.00%)    | +0.62%    | 35.759mb        | 35.759mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 972.100μs (±0.00%) | 990.600μs (±0.00%) | -1.87%    | 34.241mb        | 34.241mb   | 0.00%       |
| benchLoad10000Events ()                | 57.026ms (±0.00%)  | 56.850ms (±0.00%)  | +0.31%    | 34.241mb        | 34.241mb   | 0.00%       |
| benchSave1Event ()                     | 1.010ms (±0.00%)   | 1.101ms (±0.00%)   | -8.28%    | 34.241mb        | 34.241mb   | 0.00%       |
| benchSave10000Events ()                | 298.291ms (±0.00%) | 297.658ms (±0.00%) | +0.21%    | 34.241mb        | 34.241mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.733s (±0.00%)    | 7.826s (±0.00%)    | -1.18%    | 34.241mb        | 34.241mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.095s (±0.00%)    | 5.109s (±0.00%)    | -0.28%    | 34.242mb        | 34.242mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.440ms (±0.00%)   | 4.436ms (±0.00%)   | +0.08%    | 37.435mb        | 37.435mb   | 0.00%       |
| benchSave10000Events () | 343.079ms (±0.00%) | 343.935ms (±0.00%) | -0.25%    | 37.510mb        | 37.510mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit 5467b3d into 3.8.x Jan 15, 2025
35 of 36 checks passed
@DanielBadura DanielBadura deleted the allow-multiple-wildcards branch January 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants