Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only retry relevant subscriptions #662

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Dec 29, 2024

Previously, the following actions "setup", "boot" and "run" set all subscriptions that were in error and that the retry strategy had instructed to do so to the previous state.

If, for example, a subscription received an error when booting, it is set to the error status with an error message. If a subscription engine run is now carried out, it could happen that this subscription is set back to booting because it is supposed to be retried.

The problem here is that there may not be a boot process running, so the subscription remains in booting and you no longer have an error message because it was reset by the retry system. This is very confusing for the developer because he does not know why the status is in booting.

The logic has been adjusted so that with the actions "setup", "boot" and "run" only the subscription is retried if it previously failed in the same action.

In principle, the behavior remains the same, only the error is not deleted earlier than necessary.

@DavidBadura DavidBadura added the bug Something isn't working label Dec 29, 2024
@DavidBadura DavidBadura added this to the 3.6.1 milestone Dec 29, 2024
@DavidBadura DavidBadura force-pushed the only-retry-relevant-subscriptions branch from b30922f to 26d177c Compare December 29, 2024 18:58
Copy link

github-actions bot commented Dec 29, 2024

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 955.700μs (±0.00%) | 1.005ms (±0.00%)   | -4.94%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchLoad10000Events ()                | 49.200ms (±0.00%)  | 48.125ms (±0.00%)  | +2.23%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchSave1Event ()                     | 1.035ms (±0.00%)   | 1.080ms (±0.00%)   | -4.18%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 217.551ms (±0.00%) | 223.117ms (±0.00%) | -2.49%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.454s (±0.00%)    | 8.702s (±0.00%)    | -2.85%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.871s (±0.00%)    | 4.858s (±0.00%)    | +0.28%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.544ms (±0.00%)  | 49.181ms (±0.00%)  | +2.77%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 905.300μs (±0.00%) | 919.100μs (±0.00%) | -1.50%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 74.476ms (±0.00%) | 73.616ms (±0.00%) | +1.17%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.154s (±0.00%) | 3.156s (±0.00%) | -0.05%    | 46.382mb        | 46.382mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 920.700μs (±0.00%) | 913.600μs (±0.00%) | +0.78%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 83.380ms (±0.00%)  | 85.461ms (±0.00%)  | -2.44%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.707ms (±0.00%)   | 1.594ms (±0.00%)   | +7.03%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 246.526ms (±0.00%) | 248.778ms (±0.00%) | -0.91%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.424s (±0.00%)   | 12.663s (±0.00%)   | -1.89%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.982s (±0.00%)    | 8.962s (±0.00%)    | +0.22%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.036ms (±0.00%)   | 1.043ms (±0.00%)   | -0.61%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchLoad10000Events ()                | 56.223ms (±0.00%)  | 54.517ms (±0.00%)  | +3.13%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave1Event ()                     | 1.075ms (±0.00%)   | 1.080ms (±0.00%)   | -0.48%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Events ()                | 300.129ms (±0.00%) | 302.046ms (±0.00%) | -0.63%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.465s (±0.00%)    | 8.478s (±0.00%)    | -0.16%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.058s (±0.00%)    | 5.090s (±0.00%)    | -0.63%    | 34.862mb        | 34.862mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.428ms (±0.00%)   | 4.309ms (±0.00%)   | +2.75%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 341.124ms (±0.00%) | 341.076ms (±0.00%) | +0.01%    | 37.144mb        | 37.144mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit 94a73ae into 3.6.x Dec 29, 2024
39 of 40 checks passed
@DavidBadura DavidBadura deleted the only-retry-relevant-subscriptions branch December 29, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants