-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only retry relevant subscriptions #662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b30922f
to
26d177c
Compare
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DanielBadura
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the following actions "setup", "boot" and "run" set all subscriptions that were in error and that the retry strategy had instructed to do so to the previous state.
If, for example, a subscription received an error when booting, it is set to the error status with an error message. If a subscription engine run is now carried out, it could happen that this subscription is set back to booting because it is supposed to be retried.
The problem here is that there may not be a boot process running, so the subscription remains in booting and you no longer have an error message because it was reset by the retry system. This is very confusing for the developer because he does not know why the status is in booting.
The logic has been adjusted so that with the actions "setup", "boot" and "run" only the subscription is retried if it previously failed in the same action.
In principle, the behavior remains the same, only the error is not deleted earlier than necessary.