Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename outdated into detached in subscription engine #537

Merged
merged 1 commit into from
Mar 12, 2024
Merged

rename outdated into detached in subscription engine #537

merged 1 commit into from
Mar 12, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Mar 12, 2024 •
edited
Loading

fix #533

@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 12, 2024
@DavidBadura DavidBadura force-pushed the rename-outdated-into-detached branch from 0b7da78 to 2921e78 Compare March 12, 2024 11:57
@DavidBadura DavidBadura linked an issue Mar 12, 2024 that may be closed by this pull request
Rename "outdated" into "detached" in subscription #533
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 164.025ms (±0.00%) | 168.373ms (±0.00%) | 38.664mb        | 38.664mb   |
| benchLoad10000Events ()                | 523.200μs (±0.00%) | 520.700μs (±0.00%) | 38.664mb        | 38.664mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 166.023ms (±0.00%) | 164.062ms (±0.00%) | 38.667mb        | 38.667mb   |
| benchSave1Event ()                     | 914.300μs (±0.00%) | 908.600μs (±0.00%) | 38.667mb        | 38.667mb   |
| benchSave10000Events ()                | 477.984ms (±0.00%) | 491.754ms (±0.00%) | 38.933mb        | 38.933mb   |
| benchSave10000Aggregates ()            | 8.697s (±0.00%)    | 9.236s (±0.00%)    | 38.667mb        | 38.667mb   |
| benchSave10000AggregatesTransaction () | 7.386s (±0.00%)    | 7.428s (±0.00%)    | 38.667mb        | 38.667mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.253s (±0.00%) | 3.271s (±0.00%) | 39.066mb        | 39.066mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.287ms (±0.00%)   | 5.556ms (±0.00%)   | 42.532mb        | 42.532mb   |
| benchSave10000Events () | 632.694ms (±0.00%) | 651.310ms (±0.00%) | 42.809mb        | 42.809mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit bbe507a into 3.0.x Mar 12, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the rename-outdated-into-detached branch March 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Rename "outdated" into "detached" in subscription
2 participants
@DavidBadura @DanielBadura