Fix most SA errors, remove Trace feature, fix Header usage #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBadura
commented
Dec 30, 2024
DavidBadura
approved these changes
Dec 31, 2024
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
||
| /** @interal */ | ||
| final class CustomMessageHeaderCompilerPass implements CompilerPassInterface |
There was a problem hiding this comment.
I'm not entirely happy that we have to do it this way, but there's no other option at the moment. So it's fine for now. But I'd like to see at some point whether we can add something to the event sourcing lib to make it work better.
There was a problem hiding this comment.
Yeah, imho its related to this issue here: patchlevel/event-sourcing#524
Fix header registration
Fix tests
… the event CS fix
DanielBadura
force-pushed
the
cleanup
branch
from
f391e6f to
3c30871
Compare
|
@DavidBadura I added the |
DanielBadura
commented
Dec 31, 2024
Comment on lines
+81
to
+92
| $extension = new PatchlevelEventSourcingExtension(); | ||
| $extension->load( | ||
| [ | ||
| 'patchlevel_event_sourcing' => [ | ||
| 'connection' => [ | ||
| 'url' => 'sqlite3:///:memory:', | ||
| ], | ||
| ] | ||
| ], | ||
| $container | ||
| ); | ||
|
|
There was a problem hiding this comment.
I dislike this part here. I'm not sure though how to solve this in a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.