Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reads languages from store folder #139

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Reads languages from store folder #139

merged 3 commits into from
Jul 28, 2020

Conversation

furkanbegen
Copy link
Contributor

Fixes TODO: Read store folder and parse of localization files for this slice

yakuter
yakuter requested changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@yakuter yakuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this nice PR? Then I will be happy to merge. Thank yo so much.

internal/api/system.go Outdated Show resolved Hide resolved
@furkanbegen
Copy link
Contributor Author

Can we add a test for this nice PR? Then I will be happy to merge. Thank yo so much.

I couldn't find a way to mock content of the .store folder. I think I need help for test case.

yakuter
yakuter approved these changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@yakuter yakuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your try. I am merging now. Let me give a shot for testing.

@yakuter yakuter merged commit 20ba05f into passwall:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakuter yakuter yakuter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furkanbegen @yakuter