Feature/add health check #113 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmet Turkmen <[email protected]>
Signed-off-by: Ahmet Turkmen <[email protected]>
Signed-off-by: Ahmet Turkmen <[email protected]>
|
Note; some improvements could be done. |
mrtrkmn
commented
Jun 1, 2020
|
|
||
| var ( | ||
| // should be improved | ||
| Port = config.SetupConfigDefaults().Server.Port |
There was a problem hiding this comment.
I think, it is NOT proper way of getting port from configuration. could be improved. (Maybe organization of packages may change )
There was a problem hiding this comment.
You are right, it also bothers my eye. I will also think about it.
There was a problem hiding this comment.
Could be a static variable for test purposes.
Suggested change
| Port = config.SetupConfigDefaults().Server.Port | |
| Port = "3625" |
Signed-off-by: Ahmet Turkmen <[email protected]>
yakuter
reviewed
Jun 3, 2020
|
|
||
| var ( | ||
| // should be improved | ||
| Port = config.SetupConfigDefaults().Server.Port |
There was a problem hiding this comment.
You are right, it also bothers my eye. I will also think about it.
yakuter
approved these changes
Jun 3, 2020
|
Can you change auth_api.go file name to auth.go. Then I think the conflict will be resolved. |
Signed-off-by: Ahmet Turkmen <[email protected]>
|
This is great job. Thank you @mrturkmen06 |
yakuter
added a commit
that referenced
this pull request
Jun 3, 2020
* Create CONTRIBUTING.md * Translation (#103) * used const and var for strings * update * update * CONTRIBUTING.md file translated into Turkish. * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING-TR.md * pre-generated issue template added (#106) Signed-off-by: Ahmet Turkmen <[email protected]> * Removed unnecessary alpine image (#109) * Remove unnecessary alpine image * Fix mkdir command for docker Signed-off-by: Kaan Karakaya <[email protected]> * Fix libc for docker Signed-off-by: Kaan Karakaya <[email protected]> * password package implemented (#112) * password package implemented Signed-off-by: Ahmet Turkmen <[email protected]> * app/enc/password func updated Signed-off-by: Ahmet Turkmen <[email protected]> * rename and delete deprecated todo Signed-off-by: Ahmet Turkmen <[email protected]> * Feature/add health check #113 (#115) * check token earlier Signed-off-by: Ahmet Turkmen <[email protected]> * add /health endpoint Signed-off-by: Ahmet Turkmen <[email protected]> * add workflow to run tests Signed-off-by: Ahmet Turkmen <[email protected]> * return NoToken Err Signed-off-by: Ahmet Turkmen <[email protected]> * remove suffix Signed-off-by: Ahmet Turkmen <[email protected]> * Closes #118 * update health test * workflow db user info Co-authored-by: Recep Alaca <[email protected]> Co-authored-by: Ahmet Türkmen <[email protected]> Co-authored-by: Kaan Karakaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #113
Summary:
Related test result could be observed from here