Move module destinations to standalone entities #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
added a commit
that referenced
this pull request
Feb 12, 2025
Some useful shortcuts can be replicated in the main profile screen. Requirements: - Modules implementing `ModuleDestinationProviding` return a `navigationDestination()` to navigate to module-specific routes (e.g. OpenVPN credentials). This was done in #1166 - In order to navigate to the module routes from the main `ProfileCoordinator` view, it must have a `navigationDestination()` attached for each of the modules, without knowing the concrete route types Here is how this is accomplished in a generic fashion: 1. `ProfileEditor.navigationDestinations()` iterates over each `ModuleDestinationProviding` to return a list of `navigationDestination()`, [implemented as a `ViewModifier`](https://github.com/passepartoutvpn/passepartout/pull/1167/files#diff-11dfcbc4f6c173b133fe8eb4c54710f2ac7161cd38126735c655a8c56a62b8c0R29) 2. With this in place, module routes can be pushed with a `NavigationLink` from the main profile view 3. Lastly, in the profile view, we add a section for each module implementing `ModuleShortcutsProviding`, where the module may return a list of convenient shortcuts, e.g. in the form of the `NavigationLink` in 2 Start with some OpenVPN entries: - Provider server - Credentials (if needed) Some refactoring was necessary: - Load ModulePreferences in the module destinations via ModulePreferencesModifier, rather than in the module view (may revisit later) - Due to the above, move "Remote endpoints" from "Configuration" to a separate destination (also less messy) - Group complex module views (OpenVPN/WireGuard) into folders - Reuse `ProviderServerRow` for consistency across modules/shortcuts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple destinations from the module view so that one can navigate to them from any point of the app. Affects only OpenVPN for now.
Preparation for "profile shortcuts".