Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UX of profile editing and management #1149

Merged
merged 58 commits into from
Feb 8, 2025
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
c708868
Pack module arrow into name
keeshux Feb 5, 2025
9dce9cd
Reuse NavigatingButton in modules list
keeshux Feb 7, 2025
ba848f7
Extend NavigatingButton with Label
keeshux Feb 7, 2025
f749426
Edit profile on tap name
keeshux Feb 7, 2025
165141e
Drop markers on iOS/macOS
keeshux Feb 7, 2025
b747ff6
Show subtitle in .compact too
keeshux Feb 7, 2025
4f9cb81
Replace ... with toggle
keeshux Feb 7, 2025
c2956c5
Enhance interaction with NavigatingButton
keeshux Feb 7, 2025
0ad82c9
Add icons in "General"
keeshux Feb 7, 2025
d829306
Disable animations on card
keeshux Feb 7, 2025
9667282
Add hand cursor to installed profile
keeshux Feb 7, 2025
53e73d5
Drop unused ThemePlainButtonModifier
keeshux Feb 7, 2025
7342176
Move
keeshux Feb 7, 2025
57837d5
Omit subtitle in .compact
keeshux Feb 7, 2025
d2b68ce
Make tunnel toggle work
keeshux Feb 7, 2025
ac7bab6
Move TunnelToggle to UILibrary
keeshux Feb 7, 2025
f9843be
Handle toggle scenarios
keeshux Feb 7, 2025
de7eef1
Reuse toggle in installed profile
keeshux Feb 7, 2025
b9359c1
Reorder args
keeshux Feb 7, 2025
937be1d
Drop marginal enable/disable from context menu
keeshux Feb 7, 2025
fa4762c
Fix .cursor() on tvOS
keeshux Feb 7, 2025
c9f88ac
Drop marker and nextProfileId
keeshux Feb 7, 2025
ee667f0
Restore phone scale for attributes
keeshux Feb 7, 2025
77b3604
Rename isDisabled to canInteract
keeshux Feb 7, 2025
6752a8a
Fix logic of .isEnabled
keeshux Feb 7, 2025
b42ebe2
Simplify row layout
keeshux Feb 7, 2025
687831e
Revert "Restore phone scale for attributes"
keeshux Feb 7, 2025
4fce2aa
Move .forMainButton() to extension
keeshux Feb 7, 2025
22cf146
Generalize TunnelToggle to provide a Label
keeshux Feb 7, 2025
45d2ed4
Use TunnelToggle on TV
keeshux Feb 7, 2025
2b7d8b0
Delete TunnelToggleButton
keeshux Feb 7, 2025
2e78392
Revert vertical padding until fixed
keeshux Feb 7, 2025
e0988ba
Move color inside ConnectionStatusText
keeshux Feb 7, 2025
77b61ef
Use .secondary color for .inactive
keeshux Feb 7, 2025
9e1fb56
Integrate tunnel status into card
keeshux Feb 7, 2025
c57df5c
Move to computed vars
keeshux Feb 7, 2025
bd95cbb
Do not highlight grid cells
keeshux Feb 7, 2025
14fea8d
Use .compact in list/grid
keeshux Feb 7, 2025
8f836de
Reuse profile
keeshux Feb 7, 2025
48ce223
Move provider selector button for reuse
keeshux Feb 7, 2025
dc8dc81
Lint
keeshux Feb 7, 2025
0dcaafd
Hide modules and restore vertical padding
keeshux Feb 7, 2025
1c7e206
Add provider server selector
keeshux Feb 7, 2025
26639c2
Move to computed var
keeshux Feb 7, 2025
d146857
Set global accent like v2
keeshux Feb 7, 2025
b55e2e8
iOS: Add icons in modules list
keeshux Feb 7, 2025
608cb4e
Clean up padding
keeshux Feb 7, 2025
f0ba0c0
Move font
keeshux Feb 7, 2025
ebbc2dd
Reuse ThemeImageLabel to set scale in form
keeshux Feb 7, 2025
27fd4a5
Apply scale to module icons
keeshux Feb 7, 2025
099645c
Only downscale on iOS
keeshux Feb 7, 2025
ceff2de
Set anchor
keeshux Feb 7, 2025
75359f4
Drop keep-alive on sleep icon
keeshux Feb 8, 2025
d860922
Reword storage/sharing section
keeshux Feb 8, 2025
0288535
Revert module icons
keeshux Feb 8, 2025
0e1c7ea
Fix context menu not updating
keeshux Feb 8, 2025
3442be3
Do not apply accent to Apple TV
keeshux Feb 8, 2025
07a7dcb
Drop .sleeping icon from TV list
keeshux Feb 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
keeshux committed Feb 7, 2025
commit dc8dc810296dee9654982148224c6d798efa301c
2 changes: 1 addition & 1 deletion Packages/App/Sources/UILibrary/Views/UI/TunnelToggle.swift
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public struct TunnelTextToggle: View {

extension TunnelToggle where Label == TunnelTextToggle {
public init(_ title: String = "", tunnel: ExtendedTunnel, profile: Profile?, errorHandler: ErrorHandler, flow: ConnectionFlow?) {
self.init(tunnel: tunnel, profile: profile, errorHandler: errorHandler, flow: flow) { isOn, canInteract in
self.init(tunnel: tunnel, profile: profile, errorHandler: errorHandler, flow: flow) { isOn, _ in
TunnelTextToggle(title: title, isOn: isOn)
}
}
Expand Down