OpenVPN: Resolve issues with long negotiations #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ControlChannel - DataChannel Private instances inside Negotiator actor. Safe.
FIXME: sure about non-blocking writes?
OpenVPNSession.receiveLink() is reentrant.
Retain reason when throwing .linkFailure
keeshux
added a commit
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the naive abuse of async/await in OpenVPNSession. Encapsulate the instances of ControlChannel/DataChannel inside the Negotiator actor, so that actor-isolation for them becomes automatically unnecessary. Synchronous methods inside the actor are the way to go.
After that, handle control packets in orderly fashion, because this is not being done and may spoil negotiation very easily. Probably also happening in TunnelKit.
Ultimately, skip some unnecessary XOR processing in UDP when no XOR method is actually set.