Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing value used in deployment.yaml #29

Closed
xskrasek opened this issue Jun 22, 2023 · 1 comment
Closed

Missing value used in deployment.yaml #29

xskrasek opened this issue Jun 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@xskrasek
Copy link

Hello,

There is this value on line 137 in deployment yaml.

{{- toYaml .Values.redisProxyResources | nindent 12 }}

The value is not defined in the values.yaml file. Is this intentional?

@dlen
Copy link
Member

dlen commented Jun 22, 2023

Hey thanks for the heads up! This is totally not intentional.

Maybe we could use this to move the resources entry to some other entry.
Not sure what would be more ergonomic:

.Values.app.cache.redis.sentinelProxy.resources
Or
.Values.app.resources.redisProxy

@dlen dlen added the enhancement New feature or request label Jun 22, 2023
dlen added a commit that referenced this issue Jun 27, 2023
…lop'

GH-29: fixes #29 #29

See merge request passbolt/passbolt-ops/charts-passbolt!31
@dlen dlen closed this as completed in cc47f62 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants