-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PassageClientService
class
#13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SinaSeylani
reviewed
Sep 13, 2024
After reviewing both PassageClientService.swift and Passage.swift, I couldn't find an overrideBasePath function. Is this something you plan to add later, or is it not part of the Passage Swift roadmap? |
SinaSeylani
reviewed
Sep 13, 2024
Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
Outdated
Show resolved
Hide resolved
rickycpadilla
commented
Sep 13, 2024
Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
Outdated
Show resolved
Hide resolved
…ationController.swift
SinaSeylani
approved these changes
Sep 13, 2024
rickycpadilla
added a commit
that referenced
this pull request
Sep 17, 2024
commit eaa9b74 Author: Ricky Padilla <[email protected]> Date: Fri Sep 13 13:27:47 2024 -0600 Added `PassageClientService` class (#13) * feat(PSG-4469): add user agent to network requests, handle url override * chore: misc cleanup and refactoring * chore: remove Swift Lint from dependencies * fix: passage hosted for non-ios access issue * Update Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
rickycpadilla
added a commit
that referenced
this pull request
Sep 17, 2024
* feat(PSG-4469): add user agent to network requests, handle url override * chore: misc cleanup and refactoring * chore: remove Swift Lint from dependencies * fix: passage hosted for non-ios access issue * chore: updated openapi generated code * chore: finalized availability markers * Squashed commit of the following: commit eaa9b74 Author: Ricky Padilla <[email protected]> Date: Fri Sep 13 13:27:47 2024 -0600 Added `PassageClientService` class (#13) * feat(PSG-4469): add user agent to network requests, handle url override * chore: misc cleanup and refactoring * chore: remove Swift Lint from dependencies * fix: passage hosted for non-ios access issue * Update Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift * fix: handled swift lint warnings * Update Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
PassageClientService
class toAuthResult
return value "discardable" in auth methodsType of change
Checklist:
Jira Ticket
Please add the Jira ticket number and link.