Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PassageClientService class #13

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Added PassageClientService class #13

merged 5 commits into from
Sep 13, 2024

Conversation

rickycpadilla
Copy link
Collaborator

@rickycpadilla rickycpadilla commented Sep 13, 2024

What's New?

  • Added new PassageClientService class to
    • set custom request headers
    • allow for api base path override for testing/developing against non-production endpoints
  • Misc
    • Renamed and moved files
    • Made AuthResult return value "discardable" in auth methods
    • Removed Swift Lint as a SPM dependency so consumers aren't forced to download it
    • Misc cleanup

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jira Ticket

Please add the Jira ticket number and link.

@rickycpadilla rickycpadilla requested a review from a team as a code owner September 13, 2024 17:54
@SinaSeylani
Copy link

After reviewing both PassageClientService.swift and Passage.swift, I couldn't find an overrideBasePath function. Is this something you plan to add later, or is it not part of the Passage Swift roadmap?

@rickycpadilla
Copy link
Collaborator Author

After reviewing both PassageClientService.swift and Passage.swift, I couldn't find an overrideBasePath function. Is this something you plan to add later, or is it not part of the Passage Swift roadmap?

Good question.

I didn't like that overrideBasePath would show up during autocomplete when a customer is typing passage.. They have no need for this method, and should NOT use it.

BUT we do need a public way to override the base path when developing for Flutter and React Native. So now, to override the base path you just need to add a Passage.plist file with the base path override string.
Screenshot 2024-09-13 at 1 22 08 PM

@rickycpadilla rickycpadilla merged commit eaa9b74 into main Sep 13, 2024
@rickycpadilla rickycpadilla deleted the PSG-4469-useragent branch September 13, 2024 19:27
rickycpadilla added a commit that referenced this pull request Sep 17, 2024
commit eaa9b74
Author: Ricky Padilla <[email protected]>
Date:   Fri Sep 13 13:27:47 2024 -0600

    Added `PassageClientService` class (#13)

    * feat(PSG-4469): add user agent to network requests, handle url override

    * chore: misc cleanup and refactoring

    * chore: remove Swift Lint from dependencies

    * fix: passage hosted for non-ios access issue

    * Update Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
rickycpadilla added a commit that referenced this pull request Sep 17, 2024
* feat(PSG-4469): add user agent to network requests, handle url override

* chore: misc cleanup and refactoring

* chore: remove Swift Lint from dependencies

* fix: passage hosted for non-ios access issue

* chore: updated openapi generated code

* chore: finalized availability markers

* Squashed commit of the following:

commit eaa9b74
Author: Ricky Padilla <[email protected]>
Date:   Fri Sep 13 13:27:47 2024 -0600

    Added `PassageClientService` class (#13)

    * feat(PSG-4469): add user agent to network requests, handle url override

    * chore: misc cleanup and refactoring

    * chore: remove Swift Lint from dependencies

    * fix: passage hosted for non-ios access issue

    * Update Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift

* fix: handled swift lint warnings

* Update Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants