Commit pattern upgrade #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalgn
reviewed
Jul 26, 2020
commit-regex.js
Outdated
| @@ -0,0 +1,2 @@ | |||
| //This is a common source of truth for both the actual action and unit tests | |||
| module.exports = "^v?(\\d+\\.\\d+\\.\\d+(?:-(?:alpha|beta)\\.\\d+)?)$"; | |||
There was a problem hiding this comment.
I think it could make more sense to have a method matchCommitMessage or so, exported in index.js, and then call that method in the test. Then there would be no need for this file
There was a problem hiding this comment.
@pascalgn Sorry about that. I've now exported an object containing commitRegex to reduce future changes should the need arise to export additional objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Changes
yarn.lockin potentially unhelpful waysDisclaimer: I've never used Yarn before, so you should triple check
yarn.lockbecause I might have messed up something.