-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK examples #1
SDK examples #1
Conversation
README.md
Outdated
|
||
$partnero = new Partnero("api_key"); | ||
|
||
$partnero->partners()->list(limit: 10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let remove variable names.
README.md
Outdated
$partner = (new Partner()) | ||
->setEmail('[email protected]') | ||
->setName("Name") | ||
->setSurname("Surname") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let remove surname too, we will move to use only name in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, maybe lets leave it for partners and don't show for customers only 🤔
$partnero = new Partnero("api_key"); | ||
|
||
$partner = (new Partner()) | ||
->setEmail('[email protected]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to be consistent with double or single quotes. I'm voting for single.
README.md
Outdated
``` | ||
|
||
<a name="settings-api"></a> | ||
## Settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop settings part to the end, we need to think if we need this one at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think main thing to be consistent through all readme
No description provided.