-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase build performance w/ Gradle upgrade to 7.4 #539
Conversation
This commit contains the following changes: 1. Required settings for parallelizing test executions for each subproject 2. Settings for removing deprecated gradle settings for upgrading gradle to 7.4 3. Gradle 7.4 upgrade 4. Enable parallel gradle build 5. Upgrading the plugins As part of upgrade removing the dependency to jcenter repository
@@ -1,7 +1,7 @@ | |||
#!/usr/bin/env sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file are auto-generated by Gradle 7.4 upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several build.gradle
files have:
xml.required.set(false)
html.required.set(true)
xml.required.set(false)
Where the two xml...
lines seem to be duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! I was getting ~5 min for each local build previously. Now I'm getting around ~3.5 min.
Have the same comment Josh had provided in his review. Otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #, if available: 538
Description of changes:
See the attached issue for motivation.
This commit contains the following changes:
In addition to other fixes, to be able to use features like File System Watching by default:
https://docs.gradle.org/current/userguide/performance.html#file_system_watching
https://docs.gradle.org/current/userguide/build_cache.html
As part of upgrade removing the dependency to jcenter repository.
With these changes, apart from parallelizing builds and test executions, our major gain is in builds after the first build. This is because as appose to the current situation, the subsequent build times are dependent to the amount of incremental changes we make between each build. For example in the following, the second build is after making no changes to the first build:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.