-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes sealed class DateTimeType as it was not needed. #489
Conversation
* [SqlDataType.TIMESTAMP]. However that will be different from the | ||
* `TIMESTAMP` here. | ||
* Note: TIME and TIMESTAMP are yet to be added. | ||
* AST Node corresponding to the DATE literal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add the @param
s here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
============================================
- Coverage 82.44% 82.43% -0.01%
Complexity 1330 1330
============================================
Files 171 171
Lines 10907 10904 -3
Branches 1785 1785
============================================
- Hits 8992 8989 -3
Misses 1368 1368
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShipIt!
Resolves #388.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.