Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes sealed class DateTimeType as it was not needed. #489

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

abhikuhikar
Copy link
Contributor

Resolves #388.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* [SqlDataType.TIMESTAMP]. However that will be different from the
* `TIMESTAMP` here.
* Note: TIME and TIMESTAMP are yet to be added.
* AST Node corresponding to the DATE literal
Copy link
Contributor

@am357 am357 Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add the @params here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #489 (371b9d5) into main (58f5edb) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #489      +/-   ##
============================================
- Coverage     82.44%   82.43%   -0.01%     
  Complexity     1330     1330              
============================================
  Files           171      171              
  Lines         10907    10904       -3     
  Branches       1785     1785              
============================================
- Hits           8992     8989       -3     
  Misses         1368     1368              
  Partials        547      547              
Flag Coverage Δ
CLI 20.86% <ø> (ø)
EXAMPLES 75.14% <ø> (ø)
LANG 84.83% <86.66%> (-0.01%) ⬇️
PTS ∅ <ø> (∅)
TEST_SCRIPT 79.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lang/src/org/partiql/lang/ast/AstSerialization.kt 86.76% <0.00%> (ø)
lang/src/org/partiql/lang/ast/passes/AstWalker.kt 71.33% <0.00%> (ø)
lang/src/org/partiql/lang/ast/ast.kt 88.36% <90.00%> (-0.03%) ⬇️
...ng/src/org/partiql/lang/ast/ExprNodeToStatement.kt 93.94% <92.85%> (-0.02%) ⬇️
...ng/src/org/partiql/lang/ast/StatementToExprNode.kt 97.48% <100.00%> (-0.01%) ⬇️
...src/org/partiql/lang/ast/passes/AstRewriterBase.kt 94.80% <100.00%> (ø)
...ng/src/org/partiql/lang/eval/EvaluatingCompiler.kt 84.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f5edb...371b9d5. Read the comment docs.

Copy link
Contributor

@am357 am357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShipIt!

@abhikuhikar abhikuhikar merged commit aaa5936 into main Dec 22, 2021
@abhikuhikar abhikuhikar deleted the remove-sealedclass-datetime branch December 22, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider or justify modeling of DATE and TIME literals in their own sealed class
3 participants