Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Planner docs and cleanup #1708

Merged
merged 4 commits into from
Jan 10, 2025
Merged

[v1] Planner docs and cleanup #1708

merged 4 commits into from
Jan 10, 2025

Conversation

alancai98
Copy link
Member

Relevant Issues

  • None

Description

  • Planner package audit
  • Add javadoc for public planner APIs
  • Re-arrange planner directories
  • Remove top-level internal functions
  • Fix warnings in internal planner code + tests

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 requested a review from johnedquinn January 10, 2025 22:09
@alancai98 alancai98 self-assigned this Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (4bf549b) to head (4b549ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1708   +/-   ##
=========================================
  Coverage     80.03%   80.03%           
  Complexity       47       47           
=========================================
  Files            19       19           
  Lines           506      506           
  Branches         23       23           
=========================================
  Hits            405      405           
  Misses           88       88           
  Partials         13       13           
Flag Coverage Δ
EXAMPLES 80.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,4 +1,4 @@
package org.partiql.planner.internal.utils
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(self-review) unified the utils/util/helper subpackages to be under util

import org.partiql.ast.expr.ExprVarRef
import org.partiql.ast.expr.PathStep

internal object BinderUtils {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(self-review) previously, these were all top-level internal functions. moved to be under a designated internal object

@@ -12,7 +12,7 @@
* language governing permissions and limitations under the License.
*/

package org.partiql.planner.internal.normalize
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(self-review) unified normalize and transforms sub-packages to be under transforms. confusingly, we had some normalize code split between the two packages

Copy link

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-6979E3A) +/-
% Passing 89.67% 94.32% 4.65% ✅
Passing 5287 5561 274 ✅
Failing 609 47 -562 ✅
Ignored 0 288 288 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: 6979e3a
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2637
  • Failing in both: 17
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 2
  • PASSING in BASE but now IGNORED in TARGET: 115
  • FAILING in BASE but now PASSING in TARGET: 180
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The following 2 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. inPredicateWithTableConstructor, compileOption: PERMISSIVE
  2. notInPredicateWithTableConstructor, compileOption: PERMISSIVE

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-6979E3A). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ✅

BASE (EVAL-CB0276C) TARGET (EVAL-6979E3A) +/-
% Passing 94.32% 94.32% 0.00% ✅
Passing 5561 5561 0 ✅
Failing 47 47 0 ✅
Ignored 288 288 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: cb0276c
  • Base Engine: EVAL
  • Target Commit: 6979e3a
  • Target Engine: EVAL

Result Details

  • Passing in both: 5561
  • Failing in both: 47
  • Ignored in both: 288
  • PASSING in BASE but now FAILING in TARGET: 0
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0
  • IGNORED in BASE but now PASSING in TARGET: 0

@alancai98 alancai98 merged commit 6b07dbd into main Jan 10, 2025
14 checks passed
@alancai98 alancai98 deleted the planner-audit branch January 10, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants