[v1] Re-enable some randomized tests #1696
Conversation
CROSS-ENGINE-REPORT ❌
Testing Details
Result Details
Now FAILING Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now IGNORED Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests165 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-15879F1). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-REPORT ✅
Testing DetailsResult Details
|
| @@ -1,121 +0,0 @@ | |||
| // package org.partiql.lang.randomized.eval.builtins | |||
There was a problem hiding this comment.
(self-review) TimestampTemporalAccessor class was deleted in v1 branch so tests no longer relevant
...s/src/test/kotlin/org/partiql/lang/randomized/syntax/PartiQLParserDateTimeRandomizedTests.kt
Outdated
Show resolved
Hide resolved
...ests/src/test/kotlin/org/partiql/lang/randomized/eval/EvaluatingCompilerIntRandomizedTest.kt
Outdated
Show resolved
Hide resolved
alancai98
force-pushed
the
enable-some-randomized-tests
branch
from
71fa7c4 to
b83cdc8
Compare
| @@ -33,7 +33,7 @@ internal object DateTimeUtils { | |||
| internal fun parseTime(input: String): LocalTime { | |||
| val matcher: Matcher = TIME_PATTERN.matcher(input) | |||
| if (!matcher.matches()) throw DateTimeException( | |||
| "Expect TIME Format to be in HH-mm-ss.ddd+[+|-][hh:mm|z], received $input" | |||
| "Expect TIME Format to be in HH:mm:ss.ddd+[+|-][hh:mm|z], received $input" | |||
There was a problem hiding this comment.
(self-review) these error messages were slightly off. Should use colons rather than dashes for the time part delimiters
| ) | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
(self-review) had to rewrite a big chunk of this test file since the prior modeling was pretty confusing, especially for how it reused test cases. We could clean up these tests further, but given the time constraints, didn't want to spend too long.
| * introduction of StaticType. The behavior described in these tests is still how we should handle integer arithmetic | ||
| * in the absence of type information. | ||
| * | ||
| * TODO these tests are not correct and the implementation is not correct. The tests and implementation need to give |
There was a problem hiding this comment.
(self-review) since the implementation is currently not correct for integer overflow and these tests were not correct, chose to disable all these tests until #1697 is resolved.
alancai98
changed the title
alancai98
changed the title
alancai98
force-pushed
the
enable-some-randomized-tests
branch
from
882472b to
1bead61
Compare
Relevant Issues
Description
TimestampTemporalAccessortests since that class was removed from src filesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.