Replaces partiql-memory with standard impls. #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchowell
requested review from
johnedquinn and
alancai98
and removed request for
johnedquinn
alancai98
approved these changes
Nov 1, 2024
Comment on lines
+28
to
+36
| // TODO REMOVE ME, THIS IS REQUIRED FOR EQUALITY IN UNIT TESTS | ||
| override fun equals(other: Any?): Boolean { | ||
| if (this === other) return true | ||
| if (other !is Table) return false | ||
| return name == other.getName() | ||
| } | ||
|
|
||
| // TODO REMOVE ME, THIS IS REQUIRED FOR EQUALITY IN UNIT TESTS | ||
| override fun hashCode(): Int = name.hashCode() |
There was a problem hiding this comment.
Are these TODOs still relevant? Seems to be carried over from what was in partiql-spi/src/main/kotlin/org/partiql/spi/catalog/Table.kt
There was a problem hiding this comment.
Yes, I didn't update the unit tests or anything.
CROSS-ENGINE-REPORT ❌
Testing Details
Result Details
Now FAILING Tests ❌The following 3 test(s) were previously PASSING in BASE but are now FAILING in TARGET: Click here to see
Now IGNORED Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-332C16D). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-REPORT ✅
Testing DetailsResult Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the partiql-memory plugin since we no longer use "plugin" per-say and just adds the same implementations to the SPI package. Now customers (see test updates) can use the SPI interfaces without requiring and additional dependency by getting the standard impls via common builder pattern.
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.is pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.