-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1] Remove DML and EXEC ast nodes #1552
Conversation
bfe6404
to
c19931c
Compare
// DML | ||
// **************************************** | ||
|
||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(self-review) DML parsing tests were copied directly from PartiQLParserTest
and runs on just the PIG parser.
// **************************************** | ||
// EXEC clause parsing | ||
// **************************************** | ||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(self-review) EXEC
parsing tests were copied directly from PartiQLParserTest
and runs on just the PIG parser.
CROSS-ENGINE Conformance Report ❌
Testing DetailsResult Details
Now Failing Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests492 test(s) were previously failing in BASE (LEGACY-F6ADC8E) but now pass in TARGET (EVAL-F6ADC8E). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-LEGACY Conformance Report ❌
Testing DetailsResult Details
Now Failing Tests ❌The following 1 test(s) were previously PASSING in BASE but are now FAILING in TARGET: Click here to see
CROSS-COMMIT-EVAL Conformance Report ✅
Testing DetailsResult Details
|
Relevant Issues
CAN_CAST
andCAN_LOSSLESS_CAST
from partiql-ast #1544Description
Removes the DML and EXEC nodes from the partiql-ast.
Eventually we will want to add back the DML nodes that are spec'd out in the RFC and in SQL. The previous modeling in the
partiql-ast
may need revised since there wereDO UPDATE
with assignment)So rather than committing to the potentially problematic AST modelings in the
v1
release, I removed the nodes from the AST. We can always add those nodes back into the AST as they are needed.Also worth noting that the previous ANTLR parser supported both the spec'd features as well as some legacy DML features that we don't want to support going forward. Removing the legacy DML features simplify the parsing rules and resolve some of the existing TODOs related to parsing DML.
EXEC
is not fully spec'd out and was only added for a legacy customer. If it's ever needed afterv1
, we can add it back later.Other Information
Updated Unreleased Section in CHANGELOG: [NO]
v1
branchAny backward-incompatible changes? [YES]
v1
branchAny new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.