Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves shared dependencies to SPI #1531

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Moves shared dependencies to SPI #1531

merged 1 commit into from
Aug 2, 2024

Conversation

rchowell
Copy link
Contributor

Description

This sets up a place for shared interfaces and cleans up the partiql-types package. This is a prerequisite to error handling improvements and the shared catalog/identifiers/names from the planner metadata.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchowell rchowell requested a review from johnedquinn July 30, 2024 15:49
@rchowell rchowell changed the title V1 common Moves shared dependencies to a common package Jul 30, 2024
Copy link

github-actions bot commented Jul 30, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.49% 94.37% 1.87%
✅ Passing 5433 5544 111
❌ Failing 441 331 -110
🔶 Ignored 0 0 0
Total Tests 5874 5875 1
Number passing in both: 5183

Number failing in both: 80

Number passing in legacy engine but fail in eval engine: 251

Number failing in legacy engine but pass in eval engine: 361
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
361 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (ad129fd) ef6ec91 +/-
% Passing 92.49% 92.49% 0.00%
✅ Passing 5433 5433 0
❌ Failing 441 441 0
🔶 Ignored 0 0 0
Total Tests 5874 5874 0
Number passing in both: 5433

Number failing in both: 441

Number passing in Base (ad129fd) but now fail: 0

Number failing in Base (ad129fd) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (ad129fd) ef6ec91 +/-
% Passing 94.37% 94.37% 0.00%
✅ Passing 5544 5544 0
❌ Failing 331 331 0
🔶 Ignored 0 0 0
Total Tests 5875 5875 0
Number passing in both: 5544

Number failing in both: 331

Number passing in Base (ad129fd) but now fail: 1

Number failing in Base (ad129fd) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY

@rchowell rchowell changed the title Moves shared dependencies to a common package Moves shared dependencies to SPI Jul 31, 2024
@rchowell rchowell mentioned this pull request Jul 31, 2024
17 tasks
Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rchowell rchowell merged commit bd669ff into v1 Aug 2, 2024
14 checks passed
@rchowell rchowell deleted the v1-common branch August 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants