Add implementation of date, time, and timestamp values for PartiQLValueTextWriter
#1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5423 Number failing in both: 431 Number passing in Base (68e4849) but now fail: 0 Number failing in Base (68e4849) but now pass: 0 |
rchowell
approved these changes
Jun 25, 2024
yliuuuu
reviewed
Jun 25, 2024
partiql-types/src/main/kotlin/org/partiql/value/io/PartiQLValueTextWriter.kt
Show resolved
Hide resolved
yliuuuu
reviewed
Jun 25, 2024
yliuuuu
approved these changes
Jun 25, 2024
alancai98
added a commit
that referenced
this pull request
Jun 25, 2024
alancai98
added a commit
that referenced
this pull request
Jun 25, 2024
rchowell
pushed a commit
that referenced
this pull request
Jun 26, 2024
rchowell
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
PartiQLValueTextWritercurrently does not implement printing datetime values #1491Description
PartiQLValueTextWriterSqlDialectwill also be able to print datetime literals.Other Information
Updated Unreleased Section in CHANGELOG: [YES]
Any backward-incompatible changes? [NO]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.