Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation for like, between and in #1373

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Feb 14, 2024

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

  • Initial Implementation for Like, Between, and In operator.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • < If NO, why? >
  • Any backward-incompatible changes? [YES/NO]

    • < If YES, why? >
    • < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in
      errors for users that are using our public APIs or the entities that have public visibility in our code-base. >
  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yliuuuu yliuuuu marked this pull request as ready for review February 14, 2024 23:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (partiql-eval@8f3c7f2). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             partiql-eval    #1373   +/-   ##
===============================================
  Coverage                ?   50.32%           
  Complexity              ?     1045           
===============================================
  Files                   ?      165           
  Lines                   ?    13129           
  Branches                ?     2452           
===============================================
  Hits                    ?     6607           
  Misses                  ?     5862           
  Partials                ?      660           
Flag Coverage Δ
CLI 13.77% <0.00%> (?)
EXAMPLES 80.28% <0.00%> (?)
LANG 54.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 14, 2024

Conformance comparison report-Cross Engine

Base (eval) legacy +/-
% Passing 58.53% 92.54% 34.02%
✅ Passing 3405 5384 1979
❌ Failing 2413 434 -1979
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 3402

Number failing in both: 431

Number passing in eval engine but fail in legacy engine: 3

Number failing in eval engine but pass in legacy engine: 1982
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) are passing in eval but fail in legacy:

Click here to see
  • nullif valid cases{first:"missing",second:"missing",result:missing}, compileOption: PERMISSIVE
  • nullif valid cases{first:"missing",second:"missing",result:missing}, compileOption: LEGACY
  • missing and true, compileOption: PERMISSIVE
1982 test(s) were failing in eval but now pass in legacy. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-EVAL

Base (8f3c7f2) ab50d6d +/-
% Passing 55.12% 58.53% 3.40%
✅ Passing 3207 3405 198
❌ Failing 2611 2413 -198
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 3207

Number failing in both: 2413

Number passing in Base (8f3c7f2) but now fail: 0

Number failing in Base (8f3c7f2) but now pass: 198
198 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (8f3c7f2) ab50d6d +/-
% Passing 92.47% 92.54% 0.07%
✅ Passing 5380 5384 4
❌ Failing 438 434 -4
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5380

Number failing in both: 434

Number passing in Base (8f3c7f2) but now fail: 0

Number failing in Base (8f3c7f2) but now pass: 4
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see
  • MYSQL_SELECT_23, compileOption: PERMISSIVE

  • MYSQL_SELECT_23, compileOption: LEGACY

  • MYSQL_SELECT_29, compileOption: PERMISSIVE

  • MYSQL_SELECT_29, compileOption: LEGACY

@yliuuuu yliuuuu merged commit 0155e6a into partiql-eval Feb 19, 2024
10 checks passed
@yliuuuu yliuuuu deleted the partiql-eval-in-between branch February 19, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants