Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partiql plugin cherrypick #1349

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Jan 24, 2024

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • < If NO, why? >
  • Any backward-incompatible changes? [YES/NO]

    • < If YES, why? >
    • < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in
      errors for users that are using our public APIs or the entities that have public visibility in our code-base. >
  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.54% 3.01% -89.53%
✅ Passing 5384 175 -5209
❌ Failing 434 5644 5210
🔶 Ignored 0 0 0
Total Tests 5818 5819 1
Number passing in both: 175

Number failing in both: 434

Number passing in legacy engine but fail in eval engine: 5210

Number failing in legacy engine but pass in eval engine: 0
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (1dabd4e) 68c2d99 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5384

Number failing in both: 434

Number passing in Base (1dabd4e) but now fail: 0

Number failing in Base (1dabd4e) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (1dabd4e) 68c2d99 +/-
% Passing 3.01% 3.01% 0.00%
✅ Passing 175 175 0
❌ Failing 5644 5644 0
🔶 Ignored 0 0 0
Total Tests 5819 5819 0
Number passing in both: 175

Number failing in both: 5644

Number passing in Base (1dabd4e) but now fail: 1

Number failing in Base (1dabd4e) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • path expression with ambiguous table alias (lowercase), compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • path expression with ambiguous table alias (lowercase), compileOption: LEGACY

@yliuuuu yliuuuu marked this pull request as ready for review January 24, 2024 23:40
@yliuuuu yliuuuu requested a review from johnedquinn January 24, 2024 23:40
@yliuuuu yliuuuu merged commit 57496a9 into partiql-plugin-impl Jan 24, 2024
10 checks passed
@yliuuuu yliuuuu deleted the partiql-plugin-cherrypick branch January 24, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants