feat: Change default value of Parse Server option encodeParseObjectInCloudFunction to true
#9527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9527 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 186 186
Lines 14807 14807
=======================================
Hits 13847 13847
Misses 960 960 ☔ View full report in Codecov by Sentry. |
23 tasks
Signed-off-by: Manuel <[email protected]>
mtrezza
reviewed
Jan 12, 2025
There was a problem hiding this comment.
This looks odd. We eventually want to remove the option, but the deprecation message reads more like we're only planning to change the default value. So we cannot say that the status of the deprecation is "removed" if we just change the default value. I believe the default value should have been changed in PS7, but it wasn't, because then the order would have been:
- add deprecation in PS6 --> done
- change default value in PS7 --> not done
- remove option in PS8
We can either remove the option now or only change the default value now, correct the deprecation message and remove the option in PS9. Removing the option in PS8 would not violate our deprecation policy requirement to notify for the duration of at least 1 major release, but it's little code to maintain and due to the confusing deprecation message I'd say let's keep it for now and remove in PS9.
mtrezza
reviewed
Jan 12, 2025
Signed-off-by: Manuel <[email protected]>
mtrezza
reviewed
Jan 12, 2025
Signed-off-by: Manuel <[email protected]>
mtrezza
requested changes
Jan 12, 2025
mtrezza
reviewed
Jan 12, 2025
Signed-off-by: Manuel <[email protected]>
mtrezza
changed the title
encodeParseObjectInCloudFunction: true
mtrezza
added
the
state:breaking
|
BREAKING CHANGE: The default value of Parse Server option |
mtrezza
changed the title
encodeParseObjectInCloudFunction: trueencodeParseObjectInCloudFunction to true
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 12, 2025
# [8.0.0-alpha.5](8.0.0-alpha.4...8.0.0-alpha.5) (2025-01-12) ### Features * Change default value of Parse Server option `encodeParseObjectInCloudFunction` to `true` ([#9527](#9527)) ([5c5ad69](5c5ad69)) ### BREAKING CHANGES * The default value of Parse Server option `encodeParseObjectInCloudFunction` changes to `true`; the option has been deprecated and will be removed in a future version. ([5c5ad69](5c5ad69))
|
🎉 This change has been released in version 8.0.0-alpha.5 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 4, 2025
# [8.0.0](7.4.0...8.0.0) (2025-03-04) ### Bug Fixes * LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server ([#9616](#9616)) ([bbc6bd4](bbc6bd4)) * Push adapter not loading on some versions of Node 22 ([#9524](#9524)) ([ff7f671](ff7f671)) * Remove username from email verification and password reset process ([#8488](#8488)) ([d21dd97](d21dd97)) * Security upgrade node from 20.17.0-alpine3.20 to 20.18.2-alpine3.20 ([#9583](#9583)) ([8f85ae2](8f85ae2)) ### Features * Add dynamic master key by setting Parse Server option `masterKey` to a function ([#9582](#9582)) ([6f1d161](6f1d161)) * Add support for MongoDB `databaseOptions` keys `autoSelectFamily`, `autoSelectFamilyAttemptTimeout` ([#9579](#9579)) ([5966068](5966068)) * Add support for MongoDB `databaseOptions` keys `minPoolSize`, `connectTimeoutMS`, `socketTimeoutMS` ([#9522](#9522)) ([91618fe](91618fe)) * Add TypeScript support ([#9550](#9550)) ([59e46d0](59e46d0)) * Change default value of Parse Server option `encodeParseObjectInCloudFunction` to `true` ([#9527](#9527)) ([5c5ad69](5c5ad69)) * Deprecate `PublicAPIRouter` in favor of `PagesRouter` ([#9526](#9526)) ([7f66629](7f66629)) * Increase required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` ([#9531](#9531)) ([871e508](871e508)) * Increase required minimum Node versions to `18.20.4`, `20.18.0`, `22.12.0` ([#9521](#9521)) ([4e151cd](4e151cd)) * Increase required minimum versions to Postgres `15`, PostGIS `3.3` ([#9538](#9538)) ([89c9b54](89c9b54)) * Upgrade to express 5.0.1 ([#9530](#9530)) ([e0480df](e0480df)) * Upgrade to Parse JS SDK 6.0.0 ([#9624](#9624)) ([bf9db75](bf9db75)) ### BREAKING CHANGES * This upgrades the internally used Express framework from version 4 to 5, which may be a breaking change. If Parse Server is set up to be mounted on an Express application, we recommend to also use version 5 of the Express framework to avoid any compatibility issues. Note that even if there are no issues after upgrading, future releases of Parse Server may introduce issues if Parse Server internally relies on Express 5-specific features which are unsupported by the Express version on which it is mounted. See the Express [migration guide](https://expressjs.com/en/guide/migrating-5.html) and [release announcement](https://expressjs.com/2024/10/15/v5-release.html#breaking-changes) for more info. ([e0480df](e0480df)) * This upgrades to the Parse JS SDK 6.0.0. See the [change log](https://github.com/parse-community/Parse-SDK-JS/releases/tag/6.0.0) of the Parse JS SDK for breaking changes and more details. ([bf9db75](bf9db75)) * This removes the username from the email verification and password reset process to prevent storing personally identifiable information (PII) in server and infrastructure logs. Customized HTML pages or emails related to email verification and password reset may need to be adapted accordingly. See the new templates that come bundled with Parse Server and the [migration guide](https://github.com/parse-community/parse-server/blob/alpha/8.0.0.md) for more details. ([d21dd97](d21dd97)) * This releases increases the required minimum versions to Postgres `15`, PostGIS `3.3` and removes support for Postgres `13`, `14`, PostGIS `3.1`, `3.2`. ([89c9b54](89c9b54)) * The default value of Parse Server option `encodeParseObjectInCloudFunction` changes to `true`; the option has been deprecated and will be removed in a future version. ([5c5ad69](5c5ad69)) * This releases increases the required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` and removes support for MongoDB `4`, `5`. ([871e508](871e508)) * This releases increases the required minimum Node versions to 18.20.4, 20.18.0, 22.12.0 and removes unofficial support for Node 19. ([4e151cd](4e151cd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: FILL_THIS_OUT
Approach
Tasks