-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: re-Run Prettier on master #7608
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #7608 +/- ##
=======================================
Coverage 93.97% 93.98%
=======================================
Files 181 181
Lines 13354 13354
=======================================
+ Hits 12550 12551 +1
+ Misses 804 803 -1
Continue to review full report at Codecov.
|
Yes, thanks for your feedback, that's because an issue is currently always required for a PR. We will generally simplify the templates soon to make contribution easier. The challenge is that 95% of PRs require an issue, to prevent what we often had in the past: conversations spanning across multiple PRs and issues. If you have any idea how to solve this, I'd be glad to know. |
@sadortun do you think you could resolve the conflict so we can merge this? |
b8e51e8
to
92be3f0
Compare
I will reformat the title to use the proper commit message syntax. |
✔️ Done |
Maybe we should merge #7446 before this, since its quite a large change. |
This PR is outdated. Please just run prettier on alpha/beta/master branches to stop having to manually revert unchanged PR files that were updated by the |
New Pull Request Checklist
Issue Description
master
seems to miss a few of Prettier styling. This is just to fix that.Related issue: #n/a
Approach
TODOs before merging