Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: re-Run Prettier on master #7608

Closed

Conversation

sadortun
Copy link
Contributor

@sadortun sadortun commented Oct 6, 2021

New Pull Request Checklist

Issue Description

master seems to miss a few of Prettier styling. This is just to fix that.

Related issue: #n/a

Approach

TODOs before merging

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 6, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@sadortun
Copy link
Contributor Author

sadortun commented Oct 6, 2021

FYI @parse-github-assistant tell us we can use n/a, but does not accept it

image

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #7608 (96b1c76) into master (12eb6c8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 96b1c76 differs from pull request most recent head 92be3f0. Consider uploading reports for the commit 92be3f0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7608   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files         181      181           
  Lines       13354    13354           
=======================================
+ Hits        12550    12551    +1     
+ Misses        804      803    -1     
Impacted Files Coverage Δ
src/Adapters/Storage/Postgres/PostgresClient.js 70.00% <0.00%> (ø)
src/Security/CheckGroups/CheckGroupDatabase.js 94.73% <ø> (ø)
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 94.20% <0.00%> (+0.31%) ⬆️
src/ParseServerRESTController.js 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12eb6c8...92be3f0. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Oct 6, 2021

Yes, thanks for your feedback, that's because an issue is currently always required for a PR.

We will generally simplify the templates soon to make contribution easier. The challenge is that 95% of PRs require an issue, to prevent what we often had in the past: conversations spanning across multiple PRs and issues. If you have any idea how to solve this, I'd be glad to know.

@mtrezza
Copy link
Member

mtrezza commented Oct 18, 2021

@sadortun do you think you could resolve the conflict so we can merge this?

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title style: Re-Run Prettier on master style: re-Run Prettier on master Oct 18, 2021
@sadortun
Copy link
Contributor Author

@mtrezza

✔️ Done

@mtrezza
Copy link
Member

mtrezza commented Dec 6, 2021

Maybe we should merge #7446 before this, since its quite a large change.

@sadortun sadortun closed this Dec 6, 2021
@sadortun
Copy link
Contributor Author

sadortun commented Dec 6, 2021

@mtrezza

This PR is outdated.

Please just run prettier on alpha/beta/master branches to stop having to manually revert unchanged PR files that were updated by the pre-commit hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants